Allow Uniswap Positions to be used as collateral on the Markets page #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aloe-blend-staging canceled.
|
✅ Deploy Preview for aloe-prime canceled.
|
✅ Deploy Preview for aloe-earn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
haydenshively
force-pushed
the
hs-uniswap-positions-on-markets
branch
from
638262e to
cc21ad1
Compare
IanWoodard
reviewed
Feb 15, 2024
| const hasNoCollateral = | ||
| account.assets.token0Raw === 0 && | ||
| account.assets.token1Raw === 0 && | ||
| (account.uniswapPositions?.length || 0) === 0; |
There was a problem hiding this comment.
I agree, I usually prefer those, but for numbers you requested that I use the ||
There was a problem hiding this comment.
That is only the case when we aren't defaulting to zero
Comment on lines
+333
to
+354
| <SquareInputWithMax | ||
| size='L' | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const output = formatNumberInput(event.target.value); | ||
| if (output != null) { | ||
| setBorrowAmountStr(output); | ||
| } | ||
| }} | ||
| value={borrowAmountStr} | ||
| onMaxClick={() => { | ||
| if (eightyPercentMaxBorrowAmountStr) { | ||
| setBorrowAmountStr(eightyPercentMaxBorrowAmountStr); | ||
| } | ||
| }} | ||
| maxDisabled={ | ||
| eightyPercentMaxBorrowAmountStr === null || eightyPercentMaxBorrowAmountStr === borrowAmountStr | ||
| } | ||
| maxButtonText='80% Max' | ||
| placeholder='0.00' | ||
| fullWidth={true} | ||
| inputClassName={borrowAmountStr !== '' ? 'active' : ''} | ||
| /> |
There was a problem hiding this comment.
This could use some UX improvements, we can talk about this offline
IanWoodard
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think everything is working. Only annoying thing is that sometimes some dust is left in the BorrowerNFT after you withdraw the Uniswap position.
I'm going to do some work on the contract side to fix that up. Then we'll be able to withdraw everything and give them their ante in a single transaction (right now it requires a refresh and an extra withdraw).edit: fixedAlso, we may want to refactor the
BorrowingWidgetsoon. The data structures made sense when we were only dealing with tokens, but after this change portions of it feel a bit hacky.